[ax25-layer2] "First Code"
Steve Sampson k5okc at cox.netThu Aug 10 12:03:16 UTC 2006
- Previous message: [ax25-layer2] "First Code"
- Next message: [ax25-layer2] "First Code"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Just some minor style comments:
Those whitespace expansions of function calls to make them look like
structured code really make me dizzy:
erc = bind
(
s,
(struct sockaddr *)&lmBindingAddress,
sizeof( struct sockaddr_un )
);
I don't think calloc is very expensive, and initialization is always good:
calloc( 1, sizeof( AX25PortProxy ) )
I don't see any free()'s, but it's something to think about for the shutdown
code as it develops.
This, after just one cup of coffee. But hey! I like the socket interface, and
while kernel space sounds groovy, I think even Linus has seen the error of
his ways. Tanenbaum's Minix became this great big NOS looking monolith.
"Can the LM be implemented in kernel-space in some way?"
"No." :-)
Cheers,
Steve
- Previous message: [ax25-layer2] "First Code"
- Next message: [ax25-layer2] "First Code"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the ax25-layer2 mailing list
